Author Topic: 1.5.2 PHP-source (\n) visible on Task page  (Read 3218 times)

sidewinder

  • Newbie
  • *
  • Posts: 6
    • View Profile
1.5.2 PHP-source (\n) visible on Task page
« on: August 29, 2009, 03:04:42 pm »
Opengoo version 1.5.2
Windows 7 (RC)
Firefox 3.5.2
Xampp for Windows 1.7.2
Apache 2.2.12
PHP 5.3.0
MySQL 5.1.37 + PBXT engine

See attachment Task.png

Syrion

  • Jr. Member
  • **
  • Posts: 59
    • View Profile
    • Studio Krater v.o.f.
Re: 1.5.2 PHP-source (\n) visible on Task page
« Reply #1 on: August 29, 2009, 03:30:41 pm »
Please check the last message in the Dutch forum, there's a new translation attached (nl_nl_1.5.3.zip) which fixes this issue it contains a new nl_nl folder.

It contains a lot of improvements made by Salival and me, including fixing that particular issue. Weboffice (the manager of the dutch translation) has to review it yet, but I'm running it on my server without problems.

sidewinder

  • Newbie
  • *
  • Posts: 6
    • View Profile
Re: 1.5.2 PHP-source (\n) visible on Task page
« Reply #2 on: August 29, 2009, 05:09:22 pm »
Found it. Tks.

Although, it's a shame that the \n was replaced by <br/>.
The screen is now filled with blank lines so there's more scrolling.
I think that just deleting the \n is okay.
« Last Edit: August 29, 2009, 05:13:20 pm by sidewinder »

Syrion

  • Jr. Member
  • **
  • Posts: 59
    • View Profile
    • Studio Krater v.o.f.
Re: 1.5.2 PHP-source (\n) visible on Task page
« Reply #3 on: August 29, 2009, 05:21:21 pm »
I can't seem to get that specific help-window back, so I can't check it myself at the moment.

If there are too many linebreaks in that translation or you have other suggestions, feel free to inform us at the translation forum.

Because \n is the javascript equalivent of linebreaks I simply executed an automated \n to <br/> replace.
« Last Edit: August 29, 2009, 05:23:35 pm by Syrion »

sidewinder

  • Newbie
  • *
  • Posts: 6
    • View Profile
Re: 1.5.2 PHP-source (\n) visible on Task page
« Reply #4 on: August 30, 2009, 12:56:02 pm »
I assume that javascript will leave the content of a quoted string untouched.
The PHP parser leaves the content of the quoted string untouched or will substitude the \n with a newline wich is only visible in the source of the webpage and not on the generated page.

The quoted string is parsed bij the browser as HTML.
So if the \n is not replaced by a newline it end ups as text in the web page.
The <br/> will insert a newline.

Delete the \n and insert just one <br/> wherever you want one newline.

If you're looking for the argued window you need the Dutch localization and click on "Taken" (=Task).

Syrion

  • Jr. Member
  • **
  • Posts: 59
    • View Profile
    • Studio Krater v.o.f.
Re: 1.5.2 PHP-source (\n) visible on Task page
« Reply #5 on: August 30, 2009, 03:56:12 pm »
I closed the yellow help-window some days ago, and it doesn't show up anymore. ;)